-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why is cdk-import so slow? #10
Comments
@hoegertn is this because of the resolution between name and ARN? |
Might be. I will try to do timing tests to see where the time is lost |
The listing of the types uses all the time. It seems the filtering is done client-side or at least not efficient. There are around 10 paginated list calls and one has the result in it. So this takes 5 seconds on my env with a total runtime of 5-6 seconds. We could short-circuit this by also allowing to specify the ARN of the type. For mass generation, where the time is important, you could do one list call outside of the tool and then call it with all the arns. I was able to generate within 800ms when providing the ARN. |
Yes, I think that if an ARN is provided, the lookup should be skipped. This will definitely address the mass generation use case. That's the minimum I guess. |
From Tel-Aviv:
14 seconds?
The text was updated successfully, but these errors were encountered: