Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

Page focus is not consistently at the top of pages #1142

Closed
anikbrazeau opened this issue Jan 16, 2020 · 4 comments · Fixed by #1325
Closed

Page focus is not consistently at the top of pages #1142

anikbrazeau opened this issue Jan 16, 2020 · 4 comments · Fixed by #1325
Assignees
Labels
bug Something isn't working need for launch Cannot go live without this
Milestone

Comments

@anikbrazeau
Copy link
Member

Summary

As you click through the form, the focus loads the page at different points rather than consistently at the top. This is especially noticeable on longer pages such as the money, information, device and business pages as well as on the suspect tinfo page.

@anikbrazeau anikbrazeau added the bug Something isn't working label Jan 16, 2020
@khalidelaggan
Copy link
Contributor

Can I work on this one? I find this a great opportunity to discover the page rendering/painting engine react.

@khalidelaggan
Copy link
Contributor

A quick question no need to rush in for an answer :)

Do you always want it to scroll? As for instance if someone presses the back button you may want to take them to the location that they were on when they went back.

@anikbrazeau
Copy link
Member Author

anikbrazeau commented Jan 17, 2020

I think we want it to load at the top of the page every time so people see the title and know the context, then they can decide to scroll down.

@sastels
Copy link
Contributor

sastels commented Feb 7, 2020

This is relevant:
remix-run/react-router#5210

@sastels sastels mentioned this issue Feb 7, 2020
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working need for launch Cannot go live without this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants