Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update to go-da v0.6.x #3743

Open
Tracked by #92
tzdybal opened this issue Sep 18, 2024 · 0 comments · May be fixed by #3750
Open
Tracked by #92

feat: Update to go-da v0.6.x #3743

tzdybal opened this issue Sep 18, 2024 · 0 comments · May be fixed by #3750
Labels
external Issues created by non node team members needs:triage v0.17.0 Intended for v0.17.0 release

Comments

@tzdybal
Copy link
Member

tzdybal commented Sep 18, 2024

Overview

New go-da release contains breaking changes and is not backward compatible. All details are tracked in the epic.

The most important change from the celestia-node perspective is change of return type of GetIDs method (not backward compatible!) and addition of SubmitWithOptions. Both changes can be implemented by composition of existing functionality.

Proposed changes

GetIDs

GetIDs implementation currently depends only on blob module - there is no direct way of accessing header. The most intuitive way of resolving this is to modify da.Service to inject header getter function. It can be then used to get block time information.

SubmitWithOptions

SubmitWithOption was introduced to enable the usage of multi-account feature. Because of generic nature of go-da, the new options argument has to be parsed and interpreted by implementation. To keep things simple yet extensible, options value should be a string containing JSON object with keys corresponding to available options, like: KeyName, SignerAddress, FeeGranterAddress. For example:

{"KeyName": "secret_key"}

Those options can be trivially added to NewTxConfig call in da.Service.

@github-actions github-actions bot added needs:triage external Issues created by non node team members labels Sep 18, 2024
@renaynay renaynay added the v0.17.0 Intended for v0.17.0 release label Sep 19, 2024
@tzdybal tzdybal linked a pull request Sep 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Issues created by non node team members needs:triage v0.17.0 Intended for v0.17.0 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants