Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log error instead of aborting for restore failures #11

Open
sskaur opened this issue Mar 16, 2022 · 0 comments
Open

log error instead of aborting for restore failures #11

sskaur opened this issue Mar 16, 2022 · 0 comments

Comments

@sskaur
Copy link
Contributor

sskaur commented Mar 16, 2022

In the case of gateway groups, all gateways within the group should have identical NVMf target configurations. Upon starting, the management daemon on a gateway within the group should check for ability to restore from an established NVMf target configuration to match the group. Currently, the restore is aborted and the daemon exits if there is an issue restoring some component of the target. This ensures the gateway isn't available while having a mismatched target to the others within the group.

As @trociny points out in #9, in a case where an image in ceph is accidentally deleted, a gateway attempting to restore the bdev will always fail. This could lead to all gateways within the group dying.

Should the gateway continuously check for availability of images to maintain the correctness of the OMAP specification?

As @trociny suggests, is it better to output an error message instead of aborting on restore failure? In this case, should the gateway keep track of errors to avoid attempting to restore components that have dependencies on ones that have already failed? Ex: Restoring subsystem-A fails, the gateway logs an error, continues restoring other subsystems and components but skips attempting to restore any namespaces, hosts, listeners associated with subsystem-A.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant