When we create or delete resources inside update() we don't change the local state

[gbregman]

When a gateway creates or delete a resource because of a notification of a change in the OMAP file, we call SPDK to create or delete the resource, but we don't update the local state. The local state update is done in the same place where we update the OMAP state. As we don't update the OMAP state when we're in update(), we don't update the local state either:

            if context:
                # Update gateway state
                try:
                    json_req = json_format.MessageToJson(
                        request, preserving_proto_field_name=True)
                    self.gateway_state.add_bdev(bdev_name, json_req)
                except Exception as ex:
                    self.logger.error(
                        f"Error persisting create_bdev {bdev_name}: {ex}")
                    raise

This is the create_bdev() code. When we create the bdev inside an update() the context parameter is set to None. So, we don't get to the add_bdev() call which updates both the OMAP and local states.

[gbregman]

Looking deeper into the code I see that when the update is over we run:

                # Update local state and version
                self.local.reset(omap_state_dict)
                self.omap.set_local_version(omap_version)
                self.logger.debug("Update complete.")

which sets the local state to be identical to the OMAP one.