Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A redundant Rados connection is opened in the discovery container #725

Closed
gbregman opened this issue Jun 20, 2024 · 0 comments · Fixed by #729
Closed

A redundant Rados connection is opened in the discovery container #725

gbregman opened this issue Jun 20, 2024 · 0 comments · Fixed by #729
Assignees

Comments

@gbregman
Copy link
Contributor

The discovery code has:

    def __init__(self, config):
        self.version = 1
        self.config = config
        self.lock = threading.Lock()
        self.omap_state = OmapGatewayState(self.config, "discovery")

        self.gw_logger_object = GatewayLogger(config)
        self.logger = self.gw_logger_object.logger

        gateway_group = self.config.get_with_default("gateway", "group", "")
        self.omap_name = f"nvmeof.{gateway_group}.state" \
            if gateway_group else "nvmeof.state"
        self.logger.info(f"log pages info from omap: {self.omap_name}")

        self.ioctx = self.omap_state.open_rados_connection(config)

The Rados connection on the last line is not needed as we already do that in OmapGatewayState() constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant