Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support embrace-io/embrace-apple-sdk. #1279

Open
cgrindel opened this issue Oct 5, 2024 · 0 comments · May be fixed by #1278
Open

Support embrace-io/embrace-apple-sdk. #1279

cgrindel opened this issue Oct 5, 2024 · 0 comments · May be fixed by #1278
Labels
enhancement New feature or request

Comments

@cgrindel
Copy link
Owner

cgrindel commented Oct 5, 2024

Related Slack thread.

There are two issues:

  1. The EmbraceObjCUtilsInternal module has two module map files. The existing rules_swift_package_manager code treats this as an error. The fix is to warn the client and just use the first one that is found.
  2. The GRDB.swift package, a transitive dependency, defines a systemLibrary target. rules_swift_package_manager does not yet support these target types.
@cgrindel cgrindel added the enhancement New feature or request label Oct 5, 2024
@cgrindel cgrindel linked a pull request Oct 5, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support embrace-io/embrace-apple-sdk cgrindel/rules_swift_package_manager
1 participant
@cgrindel