Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad comments in chai.js (and elsewhere) #1425

Closed
elibarzilay opened this issue Oct 18, 2021 · 0 comments · Fixed by #1598
Closed

Bad comments in chai.js (and elsewhere) #1425

elibarzilay opened this issue Oct 18, 2021 · 0 comments · Fixed by #1598

Comments

@elibarzilay
Copy link

Looks like #451 switched many docstring comments from /** to /*! -- where the latter are comments that are not dropped by minifies / bundlers / etc, and are mainly intended for copyright notices. As a result, having chai included in a bundle that esbuild generates has a whole bunch of useless comments at the end (see below). Shouldn't these non-copyright comments use /**?

... all code ...
...
/*!
 * Module dependencies.
 */
/*!
 * Module export.
 */
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant