Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getMeasurementXY is too loose #17

Open
targos opened this issue Feb 20, 2022 · 2 comments
Open

getMeasurementXY is too loose #17

targos opened this issue Feb 20, 2022 · 2 comments

Comments

@targos
Copy link
Member

targos commented Feb 20, 2022

export function getMeasurementXY(

There are a lot of cases where the function can return undefined and then this pollutes the Analysis class where most methods can also return undefined and the user always has to check if a value was returned.

@maasencioh
Copy link
Member

I will prefer to thould throw on most of this cases, I think that is easier to handle as well

@lpatiny
Copy link
Member

lpatiny commented Feb 21, 2022

I will probably work on it because I need to evaluate if this should not return an array that could be of length 0 if there is no match by the selector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants