Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The coverage directory is included in 0.17.1 #102

Closed
graingert opened this issue Aug 24, 2016 · 3 comments
Closed

The coverage directory is included in 0.17.1 #102

graingert opened this issue Aug 24, 2016 · 3 comments

Comments

@graingert
Copy link
Contributor

The coverage directory is included in 0.17.1 https://registry.npmjs.org/http-proxy-middleware/-/http-proxy-middleware-0.17.1.tgz
@chimurai
Copy link
Owner

Thanks for reporting it. I noticed this too.

It is already fixed in: f670d6e

Haven't pushed a new version to make it effective.

@SpaceK33z
Copy link

I'd recommend to use the files option in package.json to whitelist what you want to include instead. This will probably happen again in the future when you add a new folder / change a folders name.

@chimurai
Copy link
Owner

chimurai commented Sep 6, 2016

Thanks for the tip @SpaceK33z! Didn't know about files option.
Much nicer compared to .npmignore

@chimurai chimurai mentioned this issue Sep 20, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@graingert @SpaceK33z @chimurai