Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context menu not displayed #709

Closed
mkevenaar opened this issue Nov 1, 2019 · 11 comments
Closed

Context menu not displayed #709

mkevenaar opened this issue Nov 1, 2019 · 11 comments
Assignees
Labels
Bug Issues where something has happened which was not expected or intended
Milestone

Comments

@mkevenaar
Copy link
Contributor

mkevenaar commented Nov 1, 2019

Currently with v0.17.0.0 unstable 0255 (current latest version) the context menu is not showing when you right click on an item.

This was available in v0.16.0.0

@gep13
Copy link
Member

gep13 commented Nov 1, 2019

I have just tested this, and I can confirm that the context menu seems to have been lost on the LocalSourceView however it is still working as expected on the RemoteSourceView.

At this point, not immediately clear on why this would have been lost.

@gep13
Copy link
Member

gep13 commented Nov 1, 2019

More interestingly...

The context menu works when in the tile view of the LocalSourceView, but it isn't working on the list view.

@mkevenaar
Copy link
Contributor Author

@gep13 I can confirm that I have the same results.

@punker76
Copy link
Member

punker76 commented Nov 1, 2019

@gep13 This was my fault during MahApps v2.0 alpha support, I'll fix that.

@punker76 punker76 added the Bug Issues where something has happened which was not expected or intended label Nov 1, 2019
@punker76 punker76 self-assigned this Nov 1, 2019
@punker76
Copy link
Member

punker76 commented Nov 1, 2019

@gep13 done

2019-11-01_12h21_28

@mkevenaar
Copy link
Contributor Author

@gep13 @punker76 I can confirm that it works again with unstable0256

Thank you @punker76 for your quick fix!

@gep13
Copy link
Member

gep13 commented Nov 1, 2019

@punker76 thank you very much for doing this! 🎉

@gep13
Copy link
Member

gep13 commented Nov 1, 2019

@punker76 is it possible that something else might have happened here as well? I seem to remember that we added a prerelease label on the tile view when a pre-release version was installed. Or am I misremembering that?

@gep13 gep13 added this to the 0.17.0 milestone Nov 1, 2019
@punker76
Copy link
Member

punker76 commented Nov 1, 2019

@punker76 is it possible that something else might have happened here as well? I seem to remember that we added a prerelease label on the tile view when a pre-release version was installed. Or am I misremembering that?

@gep13 I will check this later

@gep13
Copy link
Member

gep13 commented Nov 1, 2019

@punker76 so I had a quick look during the stream that I did this lunch time, and I think I was misremembering something. I don't think anything else has been lost here.

@choco-bot
Copy link

🎉 This issue has been resolved in version 0.17.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues where something has happened which was not expected or intended
Projects
None yet
Development

No branches or pull requests

4 participants