Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo or redo in source editing mode #13700

Open
wildfrontend opened this issue Mar 17, 2023 · 9 comments
Open

Undo or redo in source editing mode #13700

wildfrontend opened this issue Mar 17, 2023 · 9 comments
Labels
domain:ui/ux This issue reports a problem related to UI or UX. domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. package:source-editing support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@wildfrontend
Copy link

Provide a description of the task

is it possible do undo /redo in source editing?
it look like only can do it after close souce code mode,

What steps should be taken to fulfill the task?

πŸ“ƒ Other details

  • Browser: …
  • OS: …
  • CKEditor version: …
  • Installed CKEditor plugins: …
@wildfrontend wildfrontend added the type:task This issue reports a chore (non-production change) and other types of "todos". label Mar 17, 2023
@Witoso
Copy link
Member

Witoso commented Apr 14, 2023

Unfortunately, it's not possible right now. Let's gather the interest of the community in this issue.

@Witoso Witoso added type:improvement This issue reports a possible enhancement of an existing feature. package:source-editing domain:ui/ux This issue reports a problem related to UI or UX. and removed type:task This issue reports a chore (non-production change) and other types of "todos". labels Apr 14, 2023
@Witoso Witoso changed the title Do it can undo or redo in source editing mode? Undo or redo in source editing mode Sep 12, 2023
@Witoso Witoso added the domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. label Sep 12, 2023
@bravodivs
Copy link

bravodivs commented Sep 15, 2023

Could we suggest the addition of undo and redo in the function:
private _enableCommands(): void {
const editor = this.editor;

	for ( const command of editor.commands.commands() ) {
		command.clearForceDisabled( COMMAND_FORCE_DISABLE_ID );
	}
}

taken from ckeditor5/packages/ckeditor5-source-editing/src/sourceediting.ts

or specifically, can we NOT add 'ck-disabled' class to undo and redo buttons after switching to source editing.
Moreever, i would like to know why are we disabling them at the first place?

@Witoso
Copy link
Member

Witoso commented Sep 18, 2023

The source editor is right now a separate textarea and is not an editor's instance by itself. Commands or API calls won't have an effect on it, that's why they are disabled.

@mlncn
Copy link

mlncn commented Nov 7, 2023

Since this is to gather support, noting that undo-redo (ctrl+z working as expected) in source editing is very important to us.

@nithinnath
Copy link

Hi Team,

CKeditor5 editor window Undo / redo is not working. IS any option for that?
it look like only can do it after close source code mode! Thanks

@timwood
Copy link

timwood commented Dec 15, 2023

Why intentionally disable undo/redo keyboard shortcut functionality in any textarea, ever? Please add this standard, expected functionality to CKEditor 5's source editing mode!

@ramprassads
Copy link

Can you let us know of any plan on including this feature in the upcoming versions?

@cewernlund
Copy link

cewernlund commented Apr 18, 2024

Would like to bump this as well, my users are quite surprised that they lost this functionality with the upgrade to Ckeditor5.

There is a work around for this though, you can still right click and get access to the browsers Undo/Redo functionality - I'm not sure why Ctrl-Z is disabled though, that might be the actual bug in CKEditor5 - it's fine that the package button is disabled.

Please consider prioritizing having default browser textarea Undo/Redo in the Source Input view

@aldonace-wu aldonace-wu added the support:2 An issue reported by a commercially licensed client. label Apr 19, 2024
@flagbrad
Copy link

This would help my organization a lot, as well. We often are working in the source view of things and several of of team use Ctrl+Z and Ctrl+Y like it's second nature and are we are surprised that this isn't working.

@Reinmar Reinmar added the type:bug This issue reports a buggy (incorrect) behavior. label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. package:source-editing support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests