Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move version-specific code to CGameVersionManager #198

Open
x87 opened this issue Sep 18, 2024 · 1 comment
Open

move version-specific code to CGameVersionManager #198

x87 opened this issue Sep 18, 2024 · 1 comment

Comments

@x87
Copy link

x87 commented Sep 18, 2024

          please move it to CGameVersionManager, it's better to keep all hooks in one place for future support of more versions/games.

can be done in a follow-up PR

Originally posted by @x87 in #197 (comment)

@MiranDMC
Copy link
Collaborator

MiranDMC commented Oct 6, 2024

CGameVersionManager should be rewritten to use text identifiers instead enum. Then CLEO export can be added so other plugins can benefit from it too. It would also make possible to display meaningful error messages about some function not being supported in current game version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants