Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower certificate validity period #353

Open
nabuskey opened this issue Aug 5, 2024 · 1 comment
Open

Lower certificate validity period #353

nabuskey opened this issue Aug 5, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@nabuskey
Copy link
Contributor

nabuskey commented Aug 5, 2024

Currently, the self-signed certificates are valid for 1 year. We can probably lower it since we don't expect these clusters to live for months. I'd say a month is long enough.

idpbuilder/pkg/build/tls.go

Line 29 in 71fefc7

certificateValidLength = time.Hour * 8766

@nabuskey nabuskey added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Aug 5, 2024
@cmoulliard
Copy link
Contributor

We can probably lower it since we don't expect these clusters to live for months. I'd say a month is long enough.

Default could be 1month but user should be able to configure it using a ConfigFile (see thread PR discussion around templating support - #336)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmoulliard @nabuskey