Throbber in buttons

[stefwalter]

We have throbbers that show up in buttons, like on the 'Add Server' dialog. It changes the size of the buttons and causes flicker. Should we just disable the button and put the throbber in the empty space to the far left?

[andreasn]

I see this too.
The waiting class has a set hight and width of 28px that is bigger than the button.
I'm pretty sure I've seen throbber in buttons in other places of the UI as well.

[stefwalter]

The reason the waiting class has that size is so it can be used next to buttons. I guess we need a different class if it's used inside of a button.

But do we really want the throbber to be inside a button?

[stefwalter]

@porscheyin noted that this causes dialogs to resize and flicker. We need advice from @andreasn here.

[andreasn]

Lets try and move away from all throbbers in buttons then. In how many places do we do that currently?

[andreasn]

So the only place I could find it is the Add Server dialog. Anywhere else?

[dperpeet]

@andreasn I think we have successfully moved away from this. Can you confirm?

[martinpitt]

This hasn't been an issue in years, closing.