Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: Raft log is still read on elections #26946

Closed
bdarnell opened this issue Jun 25, 2018 · 2 comments
Closed

storage: Raft log is still read on elections #26946

bdarnell opened this issue Jun 25, 2018 · 2 comments
Assignees
@bdarnell
Labels
A-kv-replication Relating to Raft, consensus, and coordination.

Comments

@bdarnell
Copy link
Contributor

etcd-io/etcd#9073 did not actually do what was intended: it still reads the entire raft log even though it now only needs the last entry. The last index is known so the call to entries needs to be adjusted so we only load the data we need.

This change should be backported to release-2.0 because we intended for this problem to be fixed in 2.0, and it's showing up in #26830.
@bdarnell bdarnell self-assigned this Jun 25, 2018
@tbg tbg added the A-kv-replication Relating to Raft, consensus, and coordination. label Jun 25, 2018
@bdarnell bdarnell mentioned this issue Jun 25, 2018
Closed
@bdarnell
Copy link
Contributor Author

Upstream PR: etcd-io/etcd#9887

@tbg
Copy link
Member

tbg commented Jul 16, 2018

@bdarnell this is done, right?

@tbg tbg closed this as completed Jul 16, 2018
@bdarnell bdarnell mentioned this issue Jul 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdarnell bdarnell

Labels
A-kv-replication Relating to Raft, consensus, and coordination.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bdarnell @tbg