Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage/engine: TestBatchCombine failed #44767

Closed
cockroach-teamcity opened this issue Feb 5, 2020 · 2 comments
Closed

storage/engine: TestBatchCombine failed #44767

cockroach-teamcity opened this issue Feb 5, 2020 · 2 comments
Assignees
@petermattis
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Milestone
20.1

Comments

@cockroach-teamcity
Copy link
Member

(storage/engine).TestBatchCombine failed on master@fae48aa285f695cadf374bc56aa74a13ff028fb7:

=== RUN   TestBatchCombine/pebble
I200205 16:56:20.615589 84 vendor/github.com/cockroachdb/pebble/version_set.go:139  [JOB 1] MANIFEST created 000001
I200205 16:56:20.616267 84 vendor/github.com/cockroachdb/pebble/open.go:215  [JOB 1] WAL created 000002
I200205 16:56:21.107297 142 vendor/github.com/cockroachdb/pebble/db.go:1300  [JOB 2] WAL created 000004
==================
WARNING: DATA RACE
Write at 0x00c00059a0d8 by goroutine 53:
  github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble.(*DB).makeRoomForWrite()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble/db.go:1331 +0x549
  github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble.(*DB).commitWrite()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble/db.go:597 +0xf3
  github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble.(*DB).commitWrite-fm()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble/db.go:570 +0x63
  github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble.(*commitPipeline).prepare()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble/commit.go:358 +0x337
  github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble.(*commitPipeline).Commit()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble/commit.go:246 +0xcd
  github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble.(*DB).Apply()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble/db.go:535 +0x25a
  github.com/cockroachdb/cockroach/pkg/storage/engine.(*pebbleBatch).Commit()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble/batch.go:713 +0xcc
  github.com/cockroachdb/cockroach/pkg/storage/engine.TestBatchCombine.func1.1()
      /go/src/github.com/cockroachdb/cockroach/pkg/storage/engine/batch_test.go:1266 +0x257

Previous read at 0x00c00059a0d8 by goroutine 50:
  github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble.(*memTable).logInfo()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble/mem_table.go:181 +0x45
  github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble.(*DB).getInternal()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble/db.go:389 +0x6ab
  github.com/cockroachdb/cockroach/pkg/storage/engine.(*Pebble).Get()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble/db.go:346 +0xd6
  github.com/cockroachdb/cockroach/pkg/storage/engine.TestBatchCombine.func1.1()
      /go/src/github.com/cockroachdb/cockroach/pkg/storage/engine/batch_test.go:1272 +0x355

Goroutine 53 (running) created at:
  github.com/cockroachdb/cockroach/pkg/storage/engine.TestBatchCombine.func1()
      /go/src/github.com/cockroachdb/cockroach/pkg/storage/engine/batch_test.go:1253 +0x15f
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:909 +0x199

Goroutine 50 (running) created at:
  github.com/cockroachdb/cockroach/pkg/storage/engine.TestBatchCombine.func1()
      /go/src/github.com/cockroachdb/cockroach/pkg/storage/engine/batch_test.go:1253 +0x15f
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:909 +0x199
==================
FAIL	github.com/cockroachdb/cockroach/pkg/storage/engine	9.467s
More

Parameters:

  • GOFLAGS=-json
make stressrace TESTS=TestBatchCombine PKG=./pkg/storage/engine TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Feb 5, 2020
@cockroach-teamcity cockroach-teamcity added this to the 20.1 milestone Feb 5, 2020
@cockroach-teamcity
Copy link
Member Author

(storage/engine).TestBatchCombine failed on master@8c0234e81b9893a36b2a28e52ad361c03c2b8640:

=== RUN   TestBatchCombine/pebble
I200205 17:26:01.984149 128 vendor/github.com/cockroachdb/pebble/version_set.go:139  [JOB 1] MANIFEST created 000001
I200205 17:26:01.984531 128 vendor/github.com/cockroachdb/pebble/open.go:215  [JOB 1] WAL created 000002
I200205 17:26:02.508134 219 vendor/github.com/cockroachdb/pebble/db.go:1300  [JOB 2] WAL created 000004
==================
WARNING: DATA RACE
Write at 0x00c0001580d8 by goroutine 62:
  github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble.(*DB).makeRoomForWrite()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble/db.go:1331 +0x549
  github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble.(*DB).commitWrite()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble/db.go:597 +0xf3
  github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble.(*DB).commitWrite-fm()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble/db.go:570 +0x63
  github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble.(*commitPipeline).prepare()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble/commit.go:358 +0x337
  github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble.(*commitPipeline).Commit()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble/commit.go:246 +0xcd
  github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble.(*DB).Apply()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble/db.go:535 +0x25a
  github.com/cockroachdb/cockroach/pkg/storage/engine.(*pebbleBatch).Commit()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble/batch.go:713 +0xcc
  github.com/cockroachdb/cockroach/pkg/storage/engine.TestBatchCombine.func1.1()
      /go/src/github.com/cockroachdb/cockroach/pkg/storage/engine/batch_test.go:1266 +0x257

Previous read at 0x00c0001580d8 by goroutine 54:
  github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble.(*memTable).logInfo()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble/mem_table.go:181 +0x45
  github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble.(*DB).getInternal()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble/db.go:389 +0x6ab
  github.com/cockroachdb/cockroach/pkg/storage/engine.(*Pebble).Get()
      /go/src/github.com/cockroachdb/cockroach/vendor/github.com/cockroachdb/pebble/db.go:346 +0xd6
  github.com/cockroachdb/cockroach/pkg/storage/engine.TestBatchCombine.func1.1()
      /go/src/github.com/cockroachdb/cockroach/pkg/storage/engine/batch_test.go:1272 +0x355

Goroutine 62 (running) created at:
  github.com/cockroachdb/cockroach/pkg/storage/engine.TestBatchCombine.func1()
      /go/src/github.com/cockroachdb/cockroach/pkg/storage/engine/batch_test.go:1253 +0x15f
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:909 +0x199

Goroutine 54 (running) created at:
  github.com/cockroachdb/cockroach/pkg/storage/engine.TestBatchCombine.func1()
      /go/src/github.com/cockroachdb/cockroach/pkg/storage/engine/batch_test.go:1253 +0x15f
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:909 +0x199
==================
FAIL	github.com/cockroachdb/cockroach/pkg/storage/engine	11.290s
More

Parameters:

  • GOFLAGS=-json
make stressrace TESTS=TestBatchCombine PKG=./pkg/storage/engine TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

@petermattis
Copy link
Collaborator

Fixed by #44753.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermattis petermattis

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
20.1
Development

No branches or pull requests
2 participants
@petermattis @cockroach-teamcity