Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: create a "golden descriptor" upgrade test #57435

Closed
jordanlewis opened this issue Dec 3, 2020 · 1 comment
Closed

schema: create a "golden descriptor" upgrade test #57435

jordanlewis opened this issue Dec 3, 2020 · 1 comment
Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@jordanlewis
Copy link
Member

jordanlewis commented Dec 3, 2020

The issue we saw in #57032 would have been averted had we had a test that upgraded a descriptor from version 19.1 with foreign keys all the way up to 20.2.

We've been discussing a test framework that can provide such testing.

The test framework should allow the creation of a schema corpus that is pinned to a version.

For each corpus, for each version, the test should upgrade the corpus through each of the versions to the present.

@ajwerner added something similar in #57066. Maybe this is all we need? What else would we need besides that set of tests to feel like we can catch more problems of this nature?

Jira issue: CRDB-3535

@jordanlewis jordanlewis added the C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. label Dec 3, 2020
@jlinder jlinder added the T-sql-schema-deprecated Use T-sql-foundations instead label Jun 16, 2021
@postamar
Copy link
Contributor

postamar commented Mar 8, 2022

Today this fits neatly inside the broader problem of properly testing descriptor upgrades (via RunPostDeserializationChanges and RunRestoreChanges) when RESTOREing old backups. I'm concerned that our corpus of backups just isn't very large and is constrained by what can be checked in the cockroachdb git repo.

This testing story is a story which we're stakeholders in but which we do not own, so I'm closing this issue.

@postamar postamar closed this as completed Mar 8, 2022
@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Development

No branches or pull requests

3 participants