Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: Consider unifying typing algorithm comments and tests #6365

Closed
nvanbenschoten opened this issue Apr 27, 2016 · 1 comment
Closed

sql: Consider unifying typing algorithm comments and tests #6365

nvanbenschoten opened this issue Apr 27, 2016 · 1 comment
Assignees
Labels
A-sql-semantics A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) X-stale

Comments

@nvanbenschoten
Copy link
Member

From @knz with regard to type checking algorithms:

"The tests containing examples that justify each of these typing rules really ought to stand out as comments next to the rule they justify. Otherwise it is just too easy to get lost and lose track of things while reading this code.

In other words we should see these tests defined primarily right here in comments. We then should have a tool that extracts example-comments from this file (and a few others) and generate a test source from them."

@knz
Copy link
Contributor

knz commented Jun 30, 2016

Pending #6895 and #7083.

@petermattis petermattis added this to the Later milestone Feb 22, 2017
@knz knz added A-sql-semantics A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) labels Apr 28, 2018
@petermattis petermattis removed this from the Later milestone Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql-semantics A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) X-stale
Projects
None yet
Development

No branches or pull requests

4 participants