Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented settings page and better error handling #313

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implemented settings page and better error handling #313

wants to merge 1 commit into from

Conversation

adi790uu
Copy link
Contributor

@adi790uu adi790uu commented May 9, 2024

fixes: #312

  1. Improves the structure of backend code and implemented better error handling.
  2. Implements Settings Page
  3. Improvement in Play Card UI
  4. Schema changes added on Delete Cascade.

result video :

Screen.Recording.2024-05-09.at.4.40.00.PM.mp4

@adi790uu
Copy link
Contributor Author

adi790uu commented May 9, 2024

@nimit9 @hkirat

@nischal-shetty2
Copy link
Contributor

big pr fixing different things, try spliting it into multiple prs

@adi790uu
Copy link
Contributor Author

@nischal-shetty2 well it would not be the best to break this into different pr's as the changes are mainly based on implementation of settings section and we need them under a single PR and other than that I have just reorganized the codebase.

@adi790uu
Copy link
Contributor Author

I don't think it will be too hard to review this.

@nischal-shetty2
Copy link
Contributor

@nischal-shetty2 well it would not be the best to break this into different pr's as the changes are mainly based on implementation of settings section and we need them under a single PR and other than that I have just reorganized the codebase.

Oo alr i didn't go through the code but you mentioned you added better error handling as well so i suggested to split that into a different pr

@adi790uu adi790uu mentioned this pull request May 12, 2024
Open
@adi790uu
Copy link
Contributor Author

adi790uu commented Jul 8, 2024

@hkirat can you review this PR, it's opened since a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement settings page + better error handling
2 participants
@adi790uu @nischal-shetty2