Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: VENDORPATH/codeigniter4/shield/src/Models/CheckQueryReturnTrait.php at line 44 #1096

Closed
rjwmtgevolution opened this issue Apr 9, 2024 · 8 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@rjwmtgevolution
Copy link

PHP Version

8.2

CodeIgniter4 Version

4.5.0

Shield Version

1.0

Which operating systems have you tested for this bug?

Linux

Which server did you use?

apache

Database

postgresql

Did you customize Shield?

no

What happened?

composer update to 4.5.0. I went to login and got the following error

I believe this is going to Call to a member function getErrors() on null

VENDORPATH/codeigniter4/shield/src/Models/CheckQueryReturnTrait.php at line 44

Steps to Reproduce

the project was on codeigniter 4.4.7 and then I composer updated to 4.5.0 this morning

Expected Output

be able to login

Anything else?

No response

@rjwmtgevolution rjwmtgevolution added the bug Something isn't working label Apr 9, 2024
@datamweb datamweb added the duplicate This issue or pull request already exists label Apr 9, 2024
@datamweb
Copy link
Collaborator

datamweb commented Apr 9, 2024

This bug has already been fixed(see #1088). Note that Shield is not currently compatible with version 4.5.
Good work done for compatibility. You should also wait for a new version of the CI framework(maybe 4.5.1) to be released.

@datamweb datamweb closed this as completed Apr 9, 2024
@rjwmtgevolution
Copy link
Author

thank you, I appreciate the quick response.

I updated the shield code and that fixed that issue.

I am getting another error now, after logging in. I click on the back button and I end up logged in.

pg_escape_literal(): Argument #2 ($string) must be of type string, CodeIgniter\I18n\Time given

SYSTEMPATH/Database/Postgre/Connection.php at line 242

@datamweb
Copy link
Collaborator

datamweb commented Apr 9, 2024

You will need the following:
codeigniter4/CodeIgniter4#8739
codeigniter4/CodeIgniter4#8738
#1095

@rjwmtgevolution
Copy link
Author

Thank you for the update.

I am not sure what to do to put the fix in place.

I clicked on the links to review but I am not sure what to do to fix the problem.

Sorry for my ignorance.

@rjwmtgevolution
Copy link
Author

sorry, I see the update / fix on issue

#1092

@rjwmtgevolution
Copy link
Author

I am able to login now.

Thank you for your help.

@datamweb
Copy link
Collaborator

datamweb commented Apr 9, 2024

I clicked on the links to review but I am not sure what to do to fix the problem.

Select tab "Files changed".
Then you will see all the files that have changed. You should apply these changes in each of your project files.

Screenshot 2024-04-09 225049

I am able to login now.

Do not forget that this is not a fundamental solution. Use the new version as soon as it is released.

@rjwmtgevolution
Copy link
Author

perfect, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants