From 31ffc404a85663a0bc1e64920e9bf323e4ffb73c Mon Sep 17 00:00:00 2001 From: kenjis Date: Mon, 8 Apr 2024 11:00:30 +0900 Subject: [PATCH 1/2] fix: Call to a member function getErrors() on null Since CI 4.5.0, $this->validation may be null. --- src/Models/CheckQueryReturnTrait.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/Models/CheckQueryReturnTrait.php b/src/Models/CheckQueryReturnTrait.php index 496db20b9..494242d10 100644 --- a/src/Models/CheckQueryReturnTrait.php +++ b/src/Models/CheckQueryReturnTrait.php @@ -41,6 +41,8 @@ protected function checkQueryReturn($return): void protected function checkValidationError(): void { + $this->validation ??= service('validation'); + $validationErrors = $this->validation->getErrors(); if ($validationErrors !== []) { From 35bbb772c36ea013d031903f4bf7e262c51979c5 Mon Sep 17 00:00:00 2001 From: kenjis Date: Mon, 8 Apr 2024 21:21:03 +0900 Subject: [PATCH 2/2] refactor: if $this->validation is null, the model did not run validation --- src/Models/CheckQueryReturnTrait.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Models/CheckQueryReturnTrait.php b/src/Models/CheckQueryReturnTrait.php index 494242d10..b6cd0e533 100644 --- a/src/Models/CheckQueryReturnTrait.php +++ b/src/Models/CheckQueryReturnTrait.php @@ -41,7 +41,9 @@ protected function checkQueryReturn($return): void protected function checkValidationError(): void { - $this->validation ??= service('validation'); + if ($this->validation === null) { + return; + } $validationErrors = $this->validation->getErrors();