Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editorstate): watch changes on files instead of each method #333

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

danilowoz
Copy link
Member

Shift the approach of how the editorState has been updated in the Sandpack context. From now on, it watches any changes on files and then sets if the current editor has any changes performed internally.

Closes #332

@danilowoz danilowoz requested a review from alexnm January 26, 2022 10:05
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit df01c1b:

Sandbox Source
Sandpack Blog Example 1 Configuration
Sandpack "editorState" demo Issue #332

@github-actions
Copy link

Size changes

sandpack-react

Total base (gzip) Total current (gzip) +/-
160 kb 160 kb ⚠️ +121 bytes (+0.07%)
Details
Dependency name / file Base Current +/-
scheduler 5 kb File removed ⚠️
0 527 kb 522 kb 🎉 -4 kb (-0.82%)
main 452 kb 453 kb ⚠️ +534 bytes (+0.12%)
index.css 28 kb 28 kb ✅ 0 byte
@codesandbox/sandpack-react 71 kb 71 kb ⚠️ +29 bytes (+0.04%)
@code-hike/classer 1 kb 1 kb ✅ 0 byte
@codesandbox/sandpack-client 13 kb 13 kb ✅ 0 byte
@codemirror/state 35 kb 35 kb ✅ 0 byte
@codemirror/view 163 kb 163 kb ✅ 0 byte
@codemirror/closebrackets 6 kb 6 kb ✅ 0 byte
@codemirror/matchbrackets 4 kb 4 kb ✅ 0 byte
@codemirror/commands 24 kb 24 kb ✅ 0 byte
@codemirror/comment 4 kb 4 kb ✅ 0 byte
@codemirror/gutter 10 kb 10 kb ✅ 0 byte
@codemirror/highlight 12 kb 12 kb ✅ 0 byte
@codemirror/history 9 kb 9 kb ✅ 0 byte
@react-hook/intersection-observer 2 kb 2 kb ✅ 0 byte
@codemirror/lang-css 11 kb 11 kb ✅ 0 byte
@codemirror/lang-javascript 6 kb 6 kb ✅ 0 byte
@codemirror/lang-html 15 kb 15 kb ✅ 0 byte
@codemirror/text 13 kb 13 kb ✅ 0 byte
style-mod 3 kb 3 kb ✅ 0 byte
@codemirror/rangeset 16 kb 16 kb ✅ 0 byte
w3c-keyname 2 kb 2 kb ✅ 0 byte
@lezer/common 33 kb 33 kb ✅ 0 byte
@codemirror/language 19 kb 19 kb ✅ 0 byte
@react-hook/passive-layout-effect 191 bytes 191 bytes ✅ 0 byte
@lezer/css 9 kb 9 kb ✅ 0 byte
@lezer/html 12 kb 12 kb ✅ 0 byte
@lezer/javascript 53 kb 54 kb ⚠️ +540 bytes (+0.99%)
@codemirror/autocomplete 33 kb 33 kb ✅ 0 byte
@lezer/lr 30 kb 30 kb ✅ 0 byte
@codemirror/tooltip 14 kb 14 kb ✅ 0 byte
lodash.isequal 18 kb 18 kb ✅ 0 byte
codesandbox-import-utils 367 bytes 367 bytes ✅ 0 byte
react-devtools-inline 823 kb 823 kb ✅ 0 byte
webpack 487 bytes 487 bytes ✅ 0 byte
intersection-observer 13 kb 13 kb ✅ 0 byte
lz-string 9 kb 9 kb ✅ 0 byte
react-is 2 kb 2 kb ✅ 0 byte

sandpack-client

Total base (gzip) Total current (gzip) +/-
7 kb 7 kb ⚠️ +1 bytes (+0.01%)
Details
Dependency name / file Base Current +/-
main 20 kb 20 kb ✅ 0 byte
@codesandbox/sandpack-client 10 kb 10 kb ✅ 0 byte
codesandbox-import-utils 3 kb 3 kb ✅ 0 byte
lodash.isequal 18 kb 18 kb ✅ 0 byte
webpack 487 bytes 487 bytes ✅ 0 byte

Copy link
Collaborator

@alexnm alexnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danilowoz danilowoz merged commit 75ebadb into main Jan 26, 2022
@danilowoz danilowoz deleted the draft/condescending-rhodes branch January 26, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: editorState doesn't track code state
2 participants