Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): EcoLight theme #602

Merged
merged 7 commits into from
Oct 4, 2022

Conversation

D-Lite
Copy link
Contributor

@D-Lite D-Lite commented Oct 3, 2022

What kind of change does this pull request introduce?

My changes illustrated the addition of a new custom theme with guidance from ace_kyd following this this tutorial

Excited to contribute to open source this year!
codesandbox_theme

@codesandbox
Copy link

codesandbox bot commented Oct 3, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 3, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 695cf5a:

Sandbox Source
Sandpack Configuration

@acekyd acekyd requested a review from danilowoz October 3, 2022 13:10
@@ -0,0 +1,36 @@
import type { SandpackTheme } from "./types";

export const danielAwesomePro: SandpackTheme = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @D-Lite, thanks for your awesome contribution!

Your theme looks good, but I just want to point one tweak here. Every Sandpack Theme usually have a name that represents its styling or a proper name, examples: githubLight, atomDark, etc.

So, in order to go further and merging it, I'd like to ask to rename it to something that represents the theme and not the author name or generic names such as awesome and pro that don't represent very well the theme itself.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @danilowoz

This has been resolved and I just made a new commit!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot to push your changes, because I can't see it on the diff

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danilowoz, I had to push and make changes manually

Now you can see the diff.

@D-Lite D-Lite changed the title Daniel awesome theme feat(theme): EcoLight theme Oct 4, 2022
@danilowoz danilowoz merged commit c8ed057 into codesandbox:main Oct 4, 2022
@D-Lite
Copy link
Contributor Author

D-Lite commented Oct 4, 2022

Thank you @danilowoz and Ace_kyd

PR merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants