Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): deduplicate files type #932

Merged
merged 1 commit into from
May 11, 2023
Merged

Conversation

BleedingDev
Copy link
Contributor

@BleedingDev BleedingDev commented May 10, 2023

What kind of change does this pull request introduce?

Bugfix

What is the current behavior?

Closes #931

What is the new behavior?

Compliant types as specified in docs.

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

  1. Change locally in installed package
  2. Use in project, where it was problematic

Checklist

  • Documentation N/A;
  • Storybook (if applicable) N/A;
  • Tests N/A;
  • Ready to be merged;

@vercel
Copy link

vercel bot commented May 10, 2023

@pegak is attempting to deploy a commit to the CodeSandbox Team on Vercel.

A member of the Team first needs to authorize it.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 220aa7d:

Sandbox Source
Sandpack Configuration
sandpack-run-stale-value Configuration

@danilowoz
Copy link
Member

It looks good, thank you so much. Good finding

@danilowoz danilowoz merged commit c1b19ee into codesandbox:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SandpackProps do not allow extended files
2 participants