Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does Note Node not support Unicode? #2312

Closed
Hamken100per opened this issue Dec 17, 2023 · 5 comments
Closed

Does Note Node not support Unicode? #2312

Hamken100per opened this issue Dec 17, 2023 · 5 comments

Comments

@Hamken100per
Copy link

If you load a workflow entered in Japanese into Note Node from a png, the characters will be garbled.

notenode_error

@NeedsMoar
Copy link

I tried the regular unicode subrange and the windows shift-JIS compatibility for japanese and there were no problems with either.
I haven't had the time to learn any of these languages yet... thanks to how stupid English is I'm in my 40s and still learning my native language. Apologies if I somehow random-clicked out the foulest insult on the planet to some country or another.

Anyway I installed hte Japanese / Chinese / Korean support fonts after I installed Windows because I hate seeing those squares online, I'd rather see nice characters even if I don't understand them. Do you have the Japanese language pack installed?
note

@Hamken100per
Copy link
Author

Thank you for your reply.
Please forgive me for my poor communication.
The workflow was saved by selecting "Workflow Image->Export->png" from the right-click menu. (Figure below)
Isn't this feature official?

workflow_export

@NeedsMoar
Copy link

Ah sorry I missed that part. I tested and it appears to be broken for that node but only when saving workflow images... workflow image save is from @pythongosssss 's custom nodes. SVG save just hangs with that text field highlighted so I couldn't check it. PNGs saved from the animatediff video save node as sidecars to MP4s don't seem to have this issue so it's specific to whatever the workflow image save is doing.

@Hamken100per
Copy link
Author

Thank you for your reply.
It wasn't an official feature. I'm sorry.
I will report to @pythongosssss.

@NeedsMoar
Copy link

Looks related to pythongosssss/ComfyUI-Custom-Scripts#122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants