Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error of server.py after update with Google Colab #3788

Closed
lovisdotio opened this issue Jun 20, 2024 · 6 comments · Fixed by #3790
Closed

Error of server.py after update with Google Colab #3788

lovisdotio opened this issue Jun 20, 2024 · 6 comments · Fixed by #3790

Comments

@lovisdotio
Copy link

lovisdotio commented Jun 20, 2024

I have an error on server.py after the last update 10 hours ago, its make it bug. And have this error :
"/content/drive/MyDrive/AI/ComfyUI/server.py", line 541, in add_routes
assert isinstance(route, web.RouteDef)
AssertionError

Reverting the file server.py to previous version make it fix.

Pull request : #3779

@huchenlei
Copy link
Contributor

Can you adjust that assertion line to assert isinstance(route, web.RouteDef), route to print out the route?

We are planning to migrate front-end api calls to endpoint with api/ prefix for easier proxy setting.

@huchenlei
Copy link
Contributor

I suspect it is not because you are in colab env, it might be caused by some custom nodes that add static routes prior to the execution of that line of code. Can you provide a full list of custom nodes you installed?

@lovisdotio
Copy link
Author

lovisdotio commented Jun 20, 2024

Import times for custom nodes:
0.0 seconds (IMPORT FAILED): /content/drive/MyDrive/AI/ComfyUI/custom_nodes/.ipynb_checkpoints (1)
0.0 seconds (IMPORT FAILED): /content/drive/MyDrive/AI/ComfyUI/custom_nodes/pycache (1)
0.0 seconds (IMPORT FAILED): /content/drive/MyDrive/AI/ComfyUI/custom_nodes/.ipynb_checkpoints
0.0 seconds (IMPORT FAILED): /content/drive/MyDrive/AI/ComfyUI/custom_nodes/BACK
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-Image-Selector
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/klinter_nodes
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/Comfy_Dungeon
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/BAM_Nodes
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/sdxl_prompt_styler
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ControlNet-LLLite-ComfyUI
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-Logic
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/cg-use-everywhere
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-Chibi-Nodes
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI_JPS-Nodes
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-IC-Light-Native
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-sampler-lcm-alternative
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/comfy-image-saver
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-Image-Filters
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/masquerade-nodes-comfyui
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/cg-image-picker
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-DiffusionLight
0.0 seconds (IMPORT FAILED): /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-3D-Pack
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI_SimpleTiles
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI_InstantID
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/stability-ComfyUI-nodes
0.0 seconds (IMPORT FAILED): /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-Panda3d
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-QualityOfLifeSuit_Omar92
0.0 seconds (IMPORT FAILED): /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-AudioScheduler
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI_Noise
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-WD14-Tagger
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/mikey_nodes
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-IC-Light
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI_essentials
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-PixelArt-Detector
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI_experiments
0.0 seconds (IMPORT FAILED): /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-SendEmail
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI_FaceAnalysis
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyMath
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-KJNodes
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/comfyui-various
0.0 seconds (IMPORT FAILED): /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-ToonCrafter
0.0 seconds (IMPORT FAILED): /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-InstantMesh
0.0 seconds (IMPORT FAILED): /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ ComfyUI_Fill-Nodes
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-Custom-Scripts
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-DepthAnythingV2
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/steerable-motion
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-DynamiCrafterWrapper
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-Frame-Interpolation
0.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-Stable-Video-Diffusion
0.1 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/comfyui-dream-video-batches
0.1 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-Advanced-ControlNet
0.1 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI_UltimateSDUpscale
0.1 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-Geowizard
0.1 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/efficiency-nodes-comfyui
0.1 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/rgthree-comfy
0.1 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/Derfuu_ComfyUI_ModdedNodes
0.1 seconds (IMPORT FAILED): /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI_LayerStyle
0.1 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/comfyui-sound-lab
0.1 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/comfyui-dream-project
0.1 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-Mana-Nodes
0.1 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-Inspire-Pack
0.1 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI_Comfyroll_CustomNodes
0.1 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-VideoHelperSuite
0.1 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-Anyline
0.2 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/comfyui-art-venture
0.2 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/SaltAI_AudioViz
0.2 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/comfyui_segment_anything
0.2 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/comfyui_controlnet_aux
0.2 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-Gemini
0.2 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-AnimateDiff-Evolved
0.2 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI_IPAdapter_plus
0.3 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI_FizzNodes
0.3 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ymc-node-suite-comfyui
0.4 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-Easy-Use
0.4 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI_tinyterraNodes
0.4 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/comfyui-reactor-node
0.6 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-Manager
0.7 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI_ADV_CLIP_emb
0.9 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-Impact-Pack
1.1 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/SeargeSDXL
1.1 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-N-Nodes
1.2 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/comfyui-mixlab-nodes
1.3 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-SUPIR
1.5 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/comfy_mtb
1.7 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/was-node-suite-comfyui
3.0 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI-Marigold
26.1 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI_smZNodes
71.3 seconds: /content/drive/MyDrive/AI/ComfyUI/custom_nodes/ComfyUI_Custom_Nodes_AlekPet

@huchenlei
Copy link
Contributor

Wow that is a long list of ndoes. Probably I need to add custom node code analysis to my TODO list. Anyway I got the patch up, you can go and try it: #3790

@lovisdotio
Copy link
Author

sure i will give it a try in a few minutes

@lovisdotio
Copy link
Author

worked ! thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants