Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right click menu options order is unstable/indeterministic. #3883

Open
huchenlei opened this issue Jun 26, 2024 · 4 comments
Open

Right click menu options order is unstable/indeterministic. #3883

huchenlei opened this issue Jun 26, 2024 · 4 comments
Labels
Bug Something is confirmed to not be working properly. Frontend Issue relates to the frontend UI (litegraph).

Comments

@huchenlei
Copy link
Contributor

          Right click menu options are unstable.

image

Originally posted by @huchenlei in #3882 (comment)

@mcmonkey4eva mcmonkey4eva added Bug Something is confirmed to not be working properly. Frontend Issue relates to the frontend UI (litegraph). labels Jun 26, 2024
@huchenlei
Copy link
Contributor Author

Following code's execution is not derministic:

if (!group) {
options.push({
content: "Add Group For Selected Nodes",
disabled: !Object.keys(app.canvas.selected_nodes || {}).length,
callback: () => {
var group = new LiteGraph.LGraphGroup();
addNodesToGroup(group, this.selected_nodes)
app.canvas.graph.add(group);
this.graph.change();
}
});
return options;
}

@huchenlei huchenlei changed the title Right click menu options are unstable. Right click menu options order is unstable/indeterministic. Jun 26, 2024
@BrechtCorbeel
Copy link

Might be like a numpy issue if they are ordered in a numpy array, same thing happens to me with que, did not notice that one yet.

@huchenlei
Copy link
Contributor Author

Might be like a numpy issue if they are ordered in a numpy array, same thing happens to me with que, did not notice that one yet.

I think it is caused by extension invoke sequence which happens in JS. It is definitely not a numpy issue.

@BrechtCorbeel
Copy link

Could be I'm going by recent mentions of numpy version issues I stumbled upon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is confirmed to not be working properly. Frontend Issue relates to the frontend UI (litegraph).
Projects
None yet
Development

No branches or pull requests

3 participants