Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$100 bounty] Setup a PR review bot #30715

Closed
adeebshihadeh opened this issue Dec 13, 2023 · 4 comments · Fixed by #30999
Closed

[$100 bounty] Setup a PR review bot #30715

adeebshihadeh opened this issue Dec 13, 2023 · 4 comments · Fixed by #30999
Labels
bounty CI / testing good first issue Feasible for new contributers

Comments

@adeebshihadeh
Copy link
Contributor

To start, I'm thinking the bot's review just consists of checking that a template is filled out in the PR body.

  • keep PRs as drafts until the bot is done with its "review"
  • also add a special bot-review label while a PR is in the bot review phase
  • must run in GitHub Actions

Set this up on your own fork of openpilot, then make a PR here.

@mhardik003
Copy link

Can you assign this to me please?

Also could you please provide the template that you want to check along with it?

@bilalshaikh292
Copy link

heyy @adeebshihadeh is the issue still open ? I would like to contribute ?

@hritikmunde
Copy link

Hey @adeebshihadeh , do you want any specific bot on this or anything that works?

@umairjavaid
Copy link

umairjavaid commented Jan 16, 2024

Hi @adeebshihadeh, I just looked into the two PRs that is open and thought to share the next,he first PR is using a Python script to solve the issue and the second one is using the Action compose feature which allows you to run a bash script to do the work you need.

Have you thought to use open source action tools that could simplify the issue and make it easier? I was thinking to use one of the next:

https://github.com/marketplace/actions/template-validator
https://github.com/marketplace/actions/pr-description-checker

As for the label for bot review, I think just having a label at the end would be more logical since the bot review would take just a few seconds. WHat do you think?

I think my previous colleague @a0m0rajab could help and provide more insights as well.

@jnewb1 jnewb1 linked a pull request Jan 16, 2024 that will close this issue
@jnewb1 jnewb1 closed this as completed Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty CI / testing good first issue Feasible for new contributers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants