Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsoTpMessage: more sanity checks #1486

Open
sshane opened this issue Jun 30, 2023 · 0 comments · Fixed by #1487
Open

IsoTpMessage: more sanity checks #1486

sshane opened this issue Jun 30, 2023 · 0 comments · Fixed by #1487
Labels
bug enhancement

Comments

@sshane
Copy link
Contributor

sshane commented Jun 30, 2023 •
edited
Loading

We should assert we can only ever receive one single or one first frames, in case we are operating with an rx address that is actually a broadcast address and the data kind of looks correct. We have a similar check for consecutive frames to make sure we're in a good state to receive them.

Related to #1412
@sshane sshane linked a pull request Jun 30, 2023 that will close this issue
iso-tp: more checks #1487
Merged
@sshane sshane reopened this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

iso-tp: more checks commaai/panda
1 participant
@sshane