Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not retrieving all modules #35

Closed
vogloblinsky opened this issue Nov 1, 2016 · 9 comments
Closed

Not retrieving all modules #35

vogloblinsky opened this issue Nov 1, 2016 · 9 comments

Comments

@vogloblinsky
Copy link
Contributor

Using this open-source Angular 2 application : https://github.com/r-park/soundcloud-ngrx

I didn't get in the outputed json modules like : HomeModule, BrowserModule, CoreModule for examples.

The graph is below.

dependencies

Is it because they don't have "imports" ?

@manekinekko
Copy link
Member

manekinekko commented Nov 1, 2016

that's because this tool doesn't understand providers configurations yet. For instance:
{provide: APP_BASE_HREF, useValue: '/'}.

I'm working on it.

@manekinekko
Copy link
Member

It's working now. Pushed to v1.0.0-alpha.7

dependencies-1

@vogloblinsky
Copy link
Contributor Author

Thanks, i commented the line for getting the main graph.
But with v1.0.0-alpha.7 i always missing HomeModule for example in the array of modules in dependencies.json, is there any reason ?

@manekinekko
Copy link
Member

are you talking about the imports entry in dependencies.json?

image

@manekinekko
Copy link
Member

manekinekko commented Nov 1, 2016

Alright. I figure out what you mean. Let me check...

@vogloblinsky
Copy link
Contributor Author

No, the global list of modules in the main array of the json.
With some research, it seems that tsc.getSourcesFiles() didn't find HomeModule index.ts file if it not included in src/main.ts

Vincent

Le 1 nov. 2016 à 13:00, Wassim Chegham notifications@github.com a écrit :

are you talking about the imports entry in dependencies.json?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@manekinekko
Copy link
Member

yep. That's what I found out also. I'll dig more to find out why.

@manekinekko
Copy link
Member

Problem solved. I basically had to override the ts.CompilerHost interface.

Is the following graph OK?

dependencies-2

@manekinekko
Copy link
Member

Pushed to v1.0.0-alpha.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants