Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KB-H032 hook is outdated #510

Open
maksim-petukhov opened this issue Aug 21, 2023 · 2 comments
Open

KB-H032 hook is outdated #510

maksim-petukhov opened this issue Aug 21, 2023 · 2 comments

Comments

@maksim-petukhov
Copy link

It handles SystemPackageTool which is deprecated and doesn't handle tools under conan.tools.system.package_manager but it should.
@maksim-petukhov maksim-petukhov mentioned this issue Aug 21, 2023
Merged
3 tasks
@Croydon
Copy link
Contributor

Croydon commented Jun 19, 2024 •
edited
Loading

The hook should probably just forbid to use def system_requirements() altogether outside of system packages

@uilianries
Copy link
Member

We are not touching in Hooks right now, because we are re-writing the CI and Conan 2.x will be main version, so system_requirements() will not be found, resulting in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Croydon @uilianries @maksim-petukhov