Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test to check validity of the yaml files #1941

Open
hmaarrfk opened this issue Sep 28, 2021 · 2 comments
Open

Add a test to check validity of the yaml files #1941

hmaarrfk opened this issue Sep 28, 2021 · 2 comments

Comments

@hmaarrfk
Copy link
Contributor

I'm not sure why, but it seems that the jasper2 migrator had some bugs in the yaml file that caused issues after it was merged during a rerender.

I think a simple test, that tries to "read" the yaml file, to ensure there are any bugs in the yaml syntax would go a long way.

I've addressed the immediate issue in ;
#1940

@akrherz
Copy link
Contributor

akrherz commented Sep 28, 2021

I am so sorry for breaking things with jasper2.yaml. I just now reproduced what I did wrong

  • View the previous PR diff here
  • copy text shown and paste into vim jasper2.yaml file
  • saved the file and found the non-ascii characters included

@hmaarrfk
Copy link
Contributor Author

It seemed that I missed some other non-ascii characters
#1943

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants