-
-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close Python 3.12 migration #5892
Comments
I think the packages depending on pyside2 should likely consider moving to pyside6 in 2024. Given the status, i'm in favor of closing, users can add Is it possible to "soft close" it? I find the |
Yeah, good idea! 👍 That should work, at least in the sense that we'd still continue having the migrator on the status page, and PRs issued whenever an affected feedstock (with all required dependencies from the POV of the migrator) doesn't have |
i'm just not sure how "softclosing" works when we add a zip key. if it is any added maintenance, we should just close IMO |
It works. :) |
In the context of #5851, we need to either close the python 3.12 migration or accept up to 2k potentially redundant PRs, due to various issues around zips and otherwise not being able to migrate numpy 2 for python 3.12 if it's still in a migrator.
So the suggestion was floated to close the 3.12 migration, and I went through all open PRs (that have >1 children) and tried to at least diagnose, and ideally fix/merge them. As of now, we have
The last big blocker is tensorflow, for which I have a PR that's nearly done. I've tried spacy, but it's not yet compatible with 3.12 (AFAICT due to using tracing, which Cython 3.0 doesn't support for 3.12 yet). The remaining packages with a moderate number of children aren't compatible yet either, or fail due to unrelated reasons:
The percentage number at the top is a bit misleading - it reports the percentage of "PRs opened", not "PRs closed". So we're actually at ~70% with the 3.12 migration, with about ~850 feedstocks still to go. In the past years, we've mostly closed the 3.X migration once we started migrating for 3.{X+1}, but OTOH, the activity here has died down almost completely, so given the numpy 2 situation, I think this is actually worth considering.
The text was updated successfully, but these errors were encountered: