Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

combine-durations detects repo from cloned repo, not based on the repo the workflow lives in #194

Closed
2 tasks done
kenodegard opened this issue Aug 5, 2024 · 0 comments · Fixed by #195
Closed
2 tasks done

combine-durations detects repo from cloned repo, not based on the repo the workflow lives in #194

kenodegard opened this issue Aug 5, 2024 · 0 comments · Fixed by #195
Assignees
@kenodegard
Labels
in-progress issue is actively being worked on severity::2 critical; broken functionality with an unacceptably complex workaround source::anaconda created by members of Anaconda, Inc. type::bug describes erroneous operation, use severity::* to classify the type

Comments

@kenodegard
Copy link
Contributor

Checklist

  • I added a descriptive title
  • I searched open reports and couldn't find a duplicate

What happened?

There are two conditions in which combine-durations may be triggered. The most common situation is via a scheduled run (see https://github.com/conda/conda/actions/runs/10232908263/job/28310609789) but with the new update.yml workflow the action may also be triggered manually (see https://github.com/conda/conda/actions/runs/10255189131/job/28371616702).

In either case if no PR exists then we end up cloning the upstream repo allowing combine-durations to correctly detect the repository to download artifacts from. However, if a PR already exists (which typically means the PR is made via a fork) then combine-durations will incorrectly detect the fork repo as the upstream and will attempt to download test artifacts from the fork (of which there will be none).

Conda Info

No response

Conda Config

No response

Conda list

No response

Additional Context

No response
@kenodegard kenodegard added type::bug describes erroneous operation, use severity::* to classify the type in-progress issue is actively being worked on severity::2 critical; broken functionality with an unacceptably complex workaround source::anaconda created by members of Anaconda, Inc. labels Aug 5, 2024
@kenodegard kenodegard self-assigned this Aug 5, 2024
@kenodegard kenodegard mentioned this issue Aug 5, 2024
Merged
@jezdez jezdez mentioned this issue Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kenodegard kenodegard

Labels
in-progress issue is actively being worked on severity::2 critical; broken functionality with an unacceptably complex workaround source::anaconda created by members of Anaconda, Inc. type::bug describes erroneous operation, use severity::* to classify the type
Projects
🧭 Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add repository input to combine-durations conda/actions
1 participant
@kenodegard