Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_latest_schema() doesn't raise for log error for all the codes. It makes it difficult to debug #584

Open
HarmeetSokhi opened this issue Apr 16, 2019 · 0 comments

Comments

@HarmeetSokhi
Copy link

HarmeetSokhi commented Apr 16, 2019

Description

get_latest_schema() method in cached_schema_registry_client.py have the below code which makes it difficult to debug the actual error code

elif not (code >= 200 and code <= 299):
           return (None, None, None)

How to reproduce

Disconnect the schema Registry and try it will only give None .However if you want to see the actual error ,it needs to raise or at least log the error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants