fix nri removeMount does not work bug #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nri needs to pass the del mount info to containerd, so that containerd can handle the mount records that need to be deleted correctly Signed-off-by: jingtao.liang <jingtao.liang@easystack.cn>
|
/retest |
|
https://github.com/containerd/nri/blob/main/pkg/api/adjustment.go#L20-L32 for consideration... |
|
Additional consideration.. the removeMount test, linked below, only does the removeMount when the adjustment is set to "overwrite"= true.. If we are to support removal of a mount that is not an overwrite we should probably have another test for it.. https://github.com/containerd/nri/blob/main/pkg/adaptation/adaptation_suite_test.go#L453-L456 |
fix nri removeMount does not work bug
klihub
reviewed
Jun 7, 2024
| @@ -322,6 +322,11 @@ func (r *result) adjustMounts(mounts []*Mount, plugin string) error { | |||
| r.reply.adjust.Mounts = append(r.reply.adjust.Mounts, m) | |||
| } | |||
|
|
|||
| // need add del mount, containerd needs to process this del mounts | |||
There was a problem hiding this comment.
nitpick: I would change 'containerd' in the above comment to 'runtime'. Maybe rephrase to something like ' add deleted mounts, the runtime needs them to properly remove deleted mounts'.
|
@liangjingtao11 It would be nice to have a test case for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nri needs to pass the del mount info to containerd, so that containerd can handle the mount records that need to be deleted correctly
fix: #80