Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker node-sass issue #125

Closed
seognil opened this issue Feb 5, 2019 · 4 comments · Fixed by #151
Closed

docker node-sass issue #125

seognil opened this issue Feb 5, 2019 · 4 comments · Fixed by #151
Labels
bug

Comments

@seognil
Copy link
Contributor

seognil commented Feb 5, 2019 •
edited
Loading

To me, it's always unable to build css while local dev.
while up docker and browse http://localhost:1313
css file missing

But I finally found a way after try everything

cd themes/conventional-commits
npm install --save-dev node-sass
npm install
npm run build
cd ../../

and then run the docker-compose up as README said
It just worked at least
(I didn't add these changes in my latest Chinese text PR)

The error info I saw was:

Downloading binary from https://github.com/sass/...blahblah.../v4.9.3/...blahblah...
Cannot download "https://github.com/sass/...blahblah.../v4.9.3/...blahblah..."
HTTP error 404 Not Found

But it goes well after I do the npm update staff

Haven't figure out why yet
I'm in China and using Mac (maybe network issue? but really couldn't find the release when I manually check the node-sass Github repo)

Maybe it's necessary to update the deps

Or only add my case to README (if only few guys meet this issue)
(also unable to use yarn at first, haven't try that after npm worked)
@seognil seognil changed the title docker node-ssass issue docker node-sass issue Feb 5, 2019
@damianopetrungaro
Copy link
Member

I will take a look this week, ping me back if I won't reply 👍
Nice spot :D

@bcoe bcoe added the bug label Mar 16, 2019
@MSakamaki
Copy link
Contributor

MSakamaki commented May 10, 2019 •
edited
Loading

I also have this problem and found a solution.

The cause is sass:watch in npm-sctiprs of the theme.
If you build after creating content, css is not generated because scss does not change.

There are two ways to solve this:

  1. After building scss once, include in commit themes/conventional-commits/static/css/style.css
  2. add normal scss-build-tasks as npm start.

@damianopetrungaro
Copy link
Member

@MSakamaki this one seems reasonable add normal scss-build-tasks as npm start..

Do you want to do it? I can assign you on this!

@MSakamaki
Copy link
Contributor

@damianopetrungaro
Yes, leave it to me.
I will make a PR.

@MSakamaki MSakamaki mentioned this issue May 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: node-sass problem when local development
4 participants
@bcoe @MSakamaki @seognil @damianopetrungaro