Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to prometheus native histogram #5060

Closed
jeromeinsf opened this issue Dec 22, 2022 · 11 comments
Closed

Support to prometheus native histogram #5060

jeromeinsf opened this issue Dec 22, 2022 · 11 comments

Comments

@jeromeinsf
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Experimental native histogram support was released with Prometheus v0.40.x.

Describe the solution you'd like
We should implement native histogram support (behind a feature flag)

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@elliesaber
Copy link

just checking if there is any plan for supporting prometheus native histogram
great news opentelemetry collector now supports the conversion as well
open-telemetry/opentelemetry-collector-contrib#17370

@friedrichg
Copy link
Member

@amouhadi yes that is the plan

@friedrichg
Copy link
Member

#5289 this tracks how many samples for this histogram is cortex dropping. It's a start

@hkfgo
Copy link

hkfgo commented Jul 13, 2023

Hey just checking in again to see if anything's changed. Is native histogram support still on the roadmap?

@yeya24
Copy link
Contributor

yeya24 commented Jul 14, 2023

Yeah I believe it is still on the roadmap. We need to wait our upstream project Thanos to support native histograms first.

@yeya24
Copy link
Contributor

yeya24 commented Nov 19, 2023

If I understand correctly, Thanos already supports native histogram on all components other than downsampling.
We should start integrating with native histograms on Cortex

@yeya24
Copy link
Contributor

yeya24 commented Nov 27, 2023

Let me update the checklist for steps to enable native histograms. Feel free to leave comments about missing items.

Checklist

@yeya24 yeya24 modified the milestone: Release 1.17 Apr 26, 2024
@gburton1
Copy link

How's the checklist above looking? Any recent updates?

@hkfgo
Copy link

hkfgo commented Jun 18, 2024

I see an August date for native histogram support, under the cortex project page. Is that date an estimate?

@yeya24
Copy link
Contributor

yeya24 commented Jun 18, 2024

Thanks. I updated the checklist above.
I think the ingestion path is done. Query path are almost done. Things left:

  • Ruler
  • Querier queries histogram iterator when asked for float histogram

Also some more tests need to be added.
I expect it to be released as part of 1.18 release.

@yeya24
Copy link
Contributor

yeya24 commented Jul 1, 2024

With all the PRs merged, I think we can mark this issue as resolved.

I will create another issue to track any efforts post merge.

Updated: new tracking issue #6052

@yeya24 yeya24 closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

6 participants