From 365e70892e9ebcafb7e376fbe4f68694e6efba5e Mon Sep 17 00:00:00 2001 From: Chris Livingston Date: Thu, 21 Dec 2017 12:30:08 -0800 Subject: [PATCH] Style fixes and cruftslaying per rjiang's comments --- .../python_distribution/hello/test_superhello/BUILD | 2 +- .../backend/python/tasks2/python_create_distributions.py | 8 -------- .../backend/python/tasks/test_python_binary_create.py | 2 +- .../python/tasks2/test_python_create_distributions.py | 2 +- 4 files changed, 3 insertions(+), 11 deletions(-) diff --git a/examples/tests/python/example/python_distribution/hello/test_superhello/BUILD b/examples/tests/python/example/python_distribution/hello/test_superhello/BUILD index d6c56aed324..2717185f1c3 100644 --- a/examples/tests/python/example/python_distribution/hello/test_superhello/BUILD +++ b/examples/tests/python/example/python_distribution/hello/test_superhello/BUILD @@ -6,7 +6,7 @@ python_tests( name='superhello', sources=[ - 'test_superhello.py' + 'test_superhello.py' ], dependencies=[ 'examples/src/python/example/python_distribution/hello/superhello:superhello' diff --git a/src/python/pants/backend/python/tasks2/python_create_distributions.py b/src/python/pants/backend/python/tasks2/python_create_distributions.py index c4c520521ab..9fa791306e5 100644 --- a/src/python/pants/backend/python/tasks2/python_create_distributions.py +++ b/src/python/pants/backend/python/tasks2/python_create_distributions.py @@ -37,10 +37,6 @@ def prepare(cls, options, round_manager): def is_distribution(target): return isinstance(target, PythonDistribution) - @property - def local_dists_workdir(self): - return os.path.join(self.workdir, 'local_dists') - @property def cache_target_dirs(self): return True @@ -50,10 +46,6 @@ def execute(self): built_dists = set() if dist_targets: - local_dists_workdir = self.local_dists_workdir - if not os.path.exists(self.local_dists_workdir): - safe_mkdir(local_dists_workdir) - with self.invalidated(dist_targets, fingerprint_strategy=DefaultFingerprintStrategy(), invalidate_dependents=True) as invalidation_check: diff --git a/tests/python/pants_test/backend/python/tasks/test_python_binary_create.py b/tests/python/pants_test/backend/python/tasks/test_python_binary_create.py index f1838f897f0..f7be557bd1c 100644 --- a/tests/python/pants_test/backend/python/tasks/test_python_binary_create.py +++ b/tests/python/pants_test/backend/python/tasks/test_python_binary_create.py @@ -1,5 +1,5 @@ # coding=utf-8 -# Copyright 2016 Pants project contributors (see CONTRIBUTORS.md). +# Copyright 2017 Pants project contributors (see CONTRIBUTORS.md). # Licensed under the Apache License, Version 2.0 (see LICENSE). from __future__ import (absolute_import, division, generators, nested_scopes, print_function, diff --git a/tests/python/pants_test/backend/python/tasks2/test_python_create_distributions.py b/tests/python/pants_test/backend/python/tasks2/test_python_create_distributions.py index 5caedcca401..134db6e4cfe 100644 --- a/tests/python/pants_test/backend/python/tasks2/test_python_create_distributions.py +++ b/tests/python/pants_test/backend/python/tasks2/test_python_create_distributions.py @@ -1,5 +1,5 @@ # coding=utf-8 -# Copyright 2014 Pants project contributors (see CONTRIBUTORS.md). +# Copyright 2017 Pants project contributors (see CONTRIBUTORS.md). # Licensed under the Apache License, Version 2.0 (see LICENSE). from __future__ import (absolute_import, division, generators, nested_scopes, print_function,