Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weaken the invariant assumption of module account balance #11388

Closed
4 tasks
Tracked by #12825
yihuang opened this issue Mar 16, 2022 · 1 comment
Closed
4 tasks
Tracked by #12825

weaken the invariant assumption of module account balance #11388

yihuang opened this issue Mar 16, 2022 · 1 comment

Comments

@yihuang
Copy link
Collaborator

yihuang commented Mar 16, 2022

Summary

Right now, we forbid users from sending coins to module addresses, and the invariants check sth like:

balance(module_address) == sum(balance of individual items)

But it seems the chain logic behind the module address can actually work under the weakened invariants:

balance(module_address) >= sum(balance of individual items)

Shall we weaken the invariants for simpler maintainess?

Problem Definition

Proposal


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@tac0turtle
Copy link
Member

invariants are a testing feature, they are primarily used for simulations these days. I will close this issue as they should not effect mainnets

@tac0turtle tac0turtle closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants