-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Added test cases for precisionMultiplier #14576
test: Added test cases for precisionMultiplier #14576
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes seem to be correct, agree that more testcases helps in understanding the precisionMultiplier better
More test cases make easy to understand how the function actually works.
8c9fbba
to
dc9fcec
Compare
Thanks for the PR! Would you be up to add a quick go doc on the function itself, so it is extra clear then. |
@julienrbrt The comment for precisionMultiplier already exists. Please let me know If I'm missing something :) |
I see some failed test cases but It doesn't look like I can solve it. Thanks :) |
Co-authored-by: Hyunwoo Lee <denver@Hyunwoos-MacBook-Pro-2.local> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Description
More test cases make easy to understand how the function actually works.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change