Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Added test cases for precisionMultiplier #14576

Merged

Conversation

aeharvlee
Copy link
Contributor

Description

More test cases make easy to understand how the function actually works.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aeharvlee aeharvlee requested a review from a team as a code owner January 11, 2023 07:33
@aeharvlee aeharvlee changed the title Tests: Added test cases for precisionMultiplier test: Added test cases for precisionMultiplier Jan 11, 2023
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes seem to be correct, agree that more testcases helps in understanding the precisionMultiplier better

More test cases make easy to understand how the function actually works.
@aeharvlee aeharvlee force-pushed the add-testcases-to-precisionMultiplier branch from 8c9fbba to dc9fcec Compare January 11, 2023 10:04
@julienrbrt
Copy link
Member

Thanks for the PR! Would you be up to add a quick go doc on the function itself, so it is extra clear then.

@aeharvlee
Copy link
Contributor Author

@julienrbrt
Thanks for the review.
By the way, where should I add go doc (comments that explain the functions)?

The comment for precisionMultiplier already exists.

Please let me know If I'm missing something :)

@alexanderbez alexanderbez enabled auto-merge (squash) January 11, 2023 23:09
@aeharvlee
Copy link
Contributor Author

@alexanderbez
@facundomedica

I see some failed test cases but It doesn't look like I can solve it.
Please let me know if there's anything else I need to do.

Thanks :)

@alexanderbez alexanderbez merged commit a10ada1 into cosmos:main Jan 12, 2023
0xmuralik pushed a commit to 0xmuralik/cosmos-sdk that referenced this pull request Jan 12, 2023
Co-authored-by: Hyunwoo Lee <denver@Hyunwoos-MacBook-Pro-2.local>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants