Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation]: inconsistency between execution modes and ABCI 2.0 API #18914

Closed
p0mvn opened this issue Dec 28, 2023 · 3 comments · Fixed by #18915
Closed

[Documentation]: inconsistency between execution modes and ABCI 2.0 API #18914

p0mvn opened this issue Dec 28, 2023 · 3 comments · Fixed by #18915
Labels
C:ABCI T:Docs Changes and features related to documentation.

Comments

@p0mvn
Copy link
Member

p0mvn commented Dec 28, 2023

Summary

There is an execution mode for all ABCI 2.0 APIs except VerifyVoteExtensions

Why is there no execution mode for VerifyVoteExtensions while there is one for ExtendVote?

I propose either:
a) adding an execution mode for VerifyVoteExtensions for consistency. This would lead to having an execution mode for every ABCI 2.0 API.
b) removing an execution mode from ExtendVote as I see no use other than being set here

My personal preference is for a)
@p0mvn p0mvn added T:Docs Changes and features related to documentation. C:ABCI labels Dec 28, 2023
@alexanderbez
Copy link
Contributor

@p0mvn this was simply an oversight unfortunately. There should be an exec mode for VerifyVoteExtensions.

@p0mvn
Copy link
Member Author

p0mvn commented Dec 28, 2023

@p0mvn this was simply an oversight unfortunately. There should be an exec mode for VerifyVoteExtensions.

Makes sense. I'm happy to add it similar to ExtendVote

@alexanderbez alexanderbez mentioned this issue Dec 28, 2023
Merged
12 tasks
@p0mvn
Copy link
Member Author

p0mvn commented Dec 28, 2023

@p0mvn this was simply an oversight unfortunately. There should be an exec mode for VerifyVoteExtensions.

Makes sense. I'm happy to add it similar to ExtendVote

NVM, saw the PR. Thanks @alexanderbez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:ABCI T:Docs Changes and features related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(abci): add ExecModeVerifyVoteExtension cosmos/cosmos-sdk
2 participants
@alexanderbez @p0mvn