R4R: Support a proposal JSON file in submit-proposal #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mslipper
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #2062 +/- ##
========================================
Coverage 63.83% 63.83%
========================================
Files 113 113
Lines 6684 6684
========================================
Hits 4267 4267
Misses 2133 2133
Partials 284 284 |
alexanderbez
previously requested changes
Aug 16, 2018
There was a problem hiding this comment.
@mslipper thanks for the contribution! I left some feedback, but otherwise, great work.
| Or, via a json file: | ||
|
|
||
| ```bash | ||
| simplegovcli propose --proposal="test.json" |
There was a problem hiding this comment.
I suggest changing this to: $ simplegovcli propose --proposal=path/to/proposal.json
| simplegovcli propose --proposal="test.json" | ||
| ``` | ||
|
|
||
| Where test.json contains: |
x/gov/client/cli/tx.go
Outdated
| @@ -80,10 +117,42 @@ func GetCmdSubmitProposal(cdc *wire.Codec) *cobra.Command { | |||
| cmd.Flags().String(flagDescription, "", "description of proposal") | |||
| cmd.Flags().String(flagProposalType, "", "proposalType of proposal") | |||
| cmd.Flags().String(flagDeposit, "", "deposit of proposal") | |||
| cmd.Flags().String(flagProposal, "", "proposal file path") | |||
There was a problem hiding this comment.
Maybe update this to say:
Proposal file path (if this path is given, other proposal flags are ignored)
x/gov/client/cli/tx.go
Outdated
| ) | ||
|
|
||
| type proposal struct { | ||
| Title string `json:"title"` |
There was a problem hiding this comment.
I don't think we need JSON tags for this, do we?
| // GetCmdSubmitProposal implements submitting a proposal transaction command. | ||
| func GetCmdSubmitProposal(cdc *wire.Codec) *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "submit-proposal", | ||
| Short: "Submit a proposal along with an initial deposit", | ||
| Long: strings.TrimSpace(` |
There was a problem hiding this comment.
I suggest changing this to something along the lines of:
Submit a proposal along with an initial deposit. Proposal title, description, type and deposit can be given directly or through a proposal JSON file. For example:
x/gov/client/cli/tx.go
Outdated
| Submit a proposal along with an initial deposit. Takes four flags: --title, --description, --type, and --deposit. | ||
| Alternatively, you may pass a path to a .json file containing your proposal via the --proposal flag. For example: | ||
|
|
||
| $ gaiacli gov submit-proposal --proposal="proposal.json" |
There was a problem hiding this comment.
--proposal=path/to/proposal.json 👍
mslipper
force-pushed
the
issue-1776
branch
2 times, most recently
from
64f0d27
to
1cc45cf
Compare
Closes cosmos#1852. Closes cosmos#1776.
jackzampolin
changed the title
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1852.
Closes #1776.
docs/)PENDING.mdthat include links to the relevant issue or PR that most accurately describes the change.cmd/gaiaandexamples/For Admin Use: