Rename --gen-txs to --with-txs #2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mslipper
requested review from
cwgoes,
ebuchman,
rigelrozanski and
zramsay
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #2190 +/- ##
========================================
Coverage 63.62% 63.62%
========================================
Files 136 136
Lines 8270 8270
========================================
Hits 5262 5262
Misses 2652 2652
Partials 356 356 |
melekes
reviewed
Aug 30, 2018
CHANGELOG.md
Outdated
| @@ -555,7 +555,7 @@ FEATURES: | |||
| * gaiad init overhaul | |||
| * Create genesis transactions with `gaiad init gen-tx` | |||
| * New genesis account keys are automatically added to the client keybase (introduce `--client-home` flag) | |||
| * Initialize with genesis txs using `--gen-txs` flag | |||
| * Initialize with genesis txs using `--with-txs` flag | |||
There was a problem hiding this comment.
Don't think we should modify an old changelog entry
alexanderbez
previously requested changes
Aug 30, 2018
CHANGELOG.md
Outdated
| @@ -555,7 +555,7 @@ FEATURES: | |||
| * gaiad init overhaul | |||
| * Create genesis transactions with `gaiad init gen-tx` | |||
| * New genesis account keys are automatically added to the client keybase (introduce `--client-home` flag) | |||
| * Initialize with genesis txs using `--gen-txs` flag | |||
| * Initialize with genesis txs using `--with-txs` flag | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: