Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/auth: Param Store #2996

Closed
4 tasks
alexanderbez opened this issue Dec 4, 2018 · 0 comments · Fixed by #2998
Closed
4 tasks

x/auth: Param Store #2996

alexanderbez opened this issue Dec 4, 2018 · 0 comments · Fixed by #2998
Assignees
@alexanderbez

Comments

@alexanderbez
Copy link
Contributor

alexanderbez commented Dec 4, 2018 •
edited
Loading

Summary

Currently the ante handler consumes gas for signature verification via consumeSignatureVerificationGas with hardcoded values and only two supported concrete types. Now that the param store is implemented, these should be fetched from said store. This, in addition, allows other applications to use their own concrete types with their own respective costs (e.g. this is needed in Ethermint).

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez alexanderbez self-assigned this Dec 4, 2018
@alexanderbez alexanderbez changed the title Ante Handler: Use Param Store for Sig Verification Costs x/auth: Param Store Dec 4, 2018
This was referenced Dec 4, 2018
Merged
Closed
This was referenced Dec 17, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderbez alexanderbez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

R4R: Auth Module Param Store cosmos/cosmos-sdk
WIP: Auth Module Restructure cosmos/cosmos-sdk
1 participant
@alexanderbez