Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistency in error CodespaceType #3940

Closed
kwunyeung opened this issue Mar 20, 2019 · 1 comment · Fixed by #3953
Closed

Consistency in error CodespaceType #3940

kwunyeung opened this issue Mar 20, 2019 · 1 comment · Fixed by #3953
Assignees
@sabau
Labels
good first issue Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Comments

@kwunyeung
Copy link
Contributor

I found that the CodespaceType used in errors are not consistent in different modules. All modules are using lowercase module name but distr module is using DISTR.

cosmos-sdk/x/distribution/types/errors.go

Line 11 in 0684a42

DefaultCodespace sdk.CodespaceType = "DISTR"

Should all CodespaceType just use the module name like slashing does?

cosmos-sdk/x/slashing/errors.go

Line 13 in cff985f

DefaultCodespace sdk.CodespaceType = ModuleName

@alexanderbez alexanderbez added good first issue Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Mar 20, 2019
@alexanderbez
Copy link
Contributor

Good catch @kwunyeung!

@yangyanqing yangyanqing mentioned this issue Mar 20, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sabau sabau

Labels
good first issue Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Codespace should be lowercase.
4 participants
@kwunyeung @sabau @alexanderbez @jackzampolin