Issue when using generate-only without chain-id

[haasted]

Summary of Bug

There is a small issue when using the --generate-only flag and omitting the chain-id flag.

This is how it currently works (Release v0.37.4)

$ gaiacli tx send cosmos12d8c80nza2r2taavynm5u6q6t7rtdj58f5yqt5 cosmos1jm2xvf2r4qf5vmn873tzqzwyy76r54jrh9n8vs 5uatom --generate-only
{"type":"cosmos-sdk/StdTx","value":{"msg":null,"fee":{"amount":[],"gas":"0"},"signatures":null,"memo":""}}

ie. an empty transaction is output.

The cause of this is an error being ignored in cosmos-sdk/x/auth/client/utils/tx.go line 349 (current master).

If the line is changed to: return stdTx, err the output will be changed to the more informative:

$ gaiacli tx send cosmos12d8c80nza2r2taavynm5u6q6t7rtdj58f5yqt5 cosmos1jm2xvf2r4qf5vmn873tzqzwyy76r54jrh9n8vs 5uatom --generate-only
ERROR: chain ID required but not specified

Version

92d2dbe

Steps to Reproduce

Shown in bug description above.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned