x/gov/types: NewProposal unnecessarily creates a Proposal object that’s discarded on any error

[odeke-em]

Summary of Bug

This code could be improved to create the proposal only when the coast is clear

cosmos-sdk/x/gov/types/proposal.go

Lines 20 to 43 in ab24d0e

	func NewProposal(content Content, id uint64, submitTime, depositEndTime time.Time) (Proposal, error) {
	p := Proposal{
	ProposalId: id,
	Status: StatusDepositPeriod,
	FinalTallyResult: EmptyTallyResult(),
	TotalDeposit: sdk.NewCoins(),
	SubmitTime: submitTime,
	DepositEndTime: depositEndTime,
	}
	msg, ok := content.(proto.Message)
	if !ok {
	return Proposal{}, fmt.Errorf("%T does not implement proto.Message", content)
	}
	any, err := types.NewAnyWithValue(msg)
	if err != nil {
	return Proposal{}, err
	}
	p.Content = any
	return p, nil
	}

otherwise presently it expends RAM. Unfortunately because there are property assignments, memory is consumed. If it were just a variable declaration, it wouldn’t be a problem. To expend RAM, one could create many error-ing proposals.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned