We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There was a bug in CLI. TL;DR: all requests must go through ABCI. It was solved in #8549
The current solution is using reflection to construct the response for CLI. This adds an extra roundtrip.
Create factory methods to construct the concrete type. Ref: #8549 (comment)
Alternative approach is to avoid the serialization and wrap the abci.Response: #8549 (comment)
abci.Response
The text was updated successfully, but these errors were encountered:
@robert-zaremba is this still present even though we don't route through tendermint anymore?
Sorry, something went wrong.
I think this is already solved. Let's also confirm with @AmauryM
Yeah I don't think we use reflection in baseapp anymore
No branches or pull requests
Summary
There was a bug in CLI. TL;DR: all requests must go through ABCI. It was solved in #8549
Problem Definition
The current solution is using reflection to construct the response for CLI. This adds an extra roundtrip.
Proposal
Create factory methods to construct the concrete type.
Ref: #8549 (comment)
Alternative approach is to avoid the serialization and wrap the
abci.Response
: #8549 (comment)For Admin Use
The text was updated successfully, but these errors were encountered: